]> git.ipfire.org Git - people/arne_f/kernel.git/commit
fs/super.c: fix race between freeze_super() and thaw_super()
authorOleg Nesterov <oleg@redhat.com>
Mon, 26 Sep 2016 16:07:48 +0000 (18:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:45:26 +0000 (03:45 -0400)
commit39bcd9f92d534c9abe69be349ca3ea4e6a7b8a87
tree7b9cc13222d8f355d7ba381f1ad1e9018f575fd1
parent54203cf6fcf4d4519a79819aa2e90a21f98bc5e2
fs/super.c: fix race between freeze_super() and thaw_super()

commit 89f39af129382a40d7cd1f6914617282cfeee28e upstream.

Change thaw_super() to check frozen != SB_FREEZE_COMPLETE rather than
frozen == SB_UNFROZEN, otherwise it can race with freeze_super() which
drops sb->s_umount after SB_FREEZE_WRITE to preserve the lock ordering.

In this case thaw_super() will wrongly call s_op->unfreeze_fs() before
it was actually frozen, and call sb_freeze_unlock() which leads to the
unbalanced percpu_up_write(). Unfortunately lockdep can't detect this,
so this triggers misc BUG_ON()'s in kernel/rcu/sync.c.

Reported-and-tested-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/super.c