]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/bridge: panel: Check device dependency before managing device link
authorLiu Ying <victor.liu@nxp.com>
Thu, 23 Nov 2023 03:26:15 +0000 (11:26 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 24 Nov 2023 23:47:46 +0000 (00:47 +0100)
commit39d5b6a64ace77d0c11c398d272218df5f939abb
treeffd8d8942c1f9addd9990448b5a948e035b83945
parentab93edb2f94c3c0d5965be3815782472adbe3f52
drm/bridge: panel: Check device dependency before managing device link

Some panel devices already depend on DRM device, like the panel in
arch/arm/boot/dts/st/ste-ux500-samsung-skomer.dts, because DRM device is
the ancestor of those panel devices.  device_link_add() would fail by
returning a NULL pointer for those panel devices because of the existing
dependency.  So, check the dependency by calling device_is_dependent()
before adding or deleting device link between panel device and DRM device
so that the link is managed only for independent panel devices.

Fixes: 887878014534 ("drm/bridge: panel: Fix device link for DRM_BRIDGE_ATTACH_NO_CONNECTOR")
Fixes: 199cf07ebd2b ("drm/bridge: panel: Add a device link between drm device and panel device")
Reported-by: Linus Walleij <linus.walleij@linaro.org>
Closes: https://lore.kernel.org/lkml/CACRpkdaGzXD6HbiX7mVUNJAJtMEPG00Pp6+nJ1P0JrfJ-ArMvQ@mail.gmail.com/T/
Tested-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231123032615.3760488-1-victor.liu@nxp.com
drivers/gpu/drm/bridge/panel.c