]> git.ipfire.org Git - people/arne_f/kernel.git/commit
appletalk: Fix potential NULL pointer dereference in unregister_snap_client
authorYueHaibing <yuehaibing@huawei.com>
Thu, 14 Mar 2019 05:47:59 +0000 (13:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Dec 2019 19:38:59 +0000 (20:38 +0100)
commit39de8cc3678f5cd1f4e0ae274c20acabbd85a8b1
treef140164db177df8c9dafc8be3c442e98510bb78c
parentf70609f898d63973388b36adf3650489311b13b9
appletalk: Fix potential NULL pointer dereference in unregister_snap_client

commit 9804501fa1228048857910a6bf23e085aade37cc upstream.

register_snap_client may return NULL, all the callers
check it, but only print a warning. This will result in
NULL pointer dereference in unregister_snap_client and other
places.

It has always been used like this since v2.6

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to <4.15: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/atalk.h
net/appletalk/aarp.c
net/appletalk/ddp.c