]> git.ipfire.org Git - thirdparty/libvirt.git/commit
network_conf: Forbid commas in DNS TXT
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 23 Feb 2015 12:19:16 +0000 (13:19 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 24 Feb 2015 09:07:47 +0000 (10:07 +0100)
commit39df9d2f12829a8f1e50d78d5952ba367d6c3343
tree7cfa62dd78a9b62a9ca92096846c0f006921eced
parent8e6ee9f280b258e058a876413654ed827ca37077
network_conf: Forbid commas in DNS TXT

https://bugzilla.redhat.com/show_bug.cgi?id=1151942

While the restriction doesn't have origin in any RFC, it matters
to us while constructing the dnsmasq config file (or command line
previously). For better picture, this is how the corresponding
part of network XML look like:

  <dns>
    <forwarder addr='8.8.4.4'/>
    <txt name='example' value='example value'/>
  </dns>

And this is how the config file looks like then:

  server=8.8.4.4
  txt-record=example,example value

Now we can see why there can't be any commas in the TXT name.
They are used by dnsmasq to separate @name and @value.

Funny, we have it in the documentation, but the code (which was
pushed back in 2011) didn't reflect that.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/network_conf.c