]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Replace reset_agent with direct call from connection
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 5 Mar 2021 22:34:10 +0000 (17:34 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sun, 7 Mar 2021 04:15:17 +0000 (23:15 -0500)
commit3a378f0b22e1745509d88b923123dc38d8014274
tree669ad5260463d43307a4d33fc8eead88248fb0f3
parent1f3ef9817453faa021544841d10b5b7107b57916
Replace reset_agent with direct call from connection

Fixed a regression where the "reset agent" of the connection pool wasn't
really being utilized by the :class:`_engine.Connection` when it were
closed, and also leading to a double-rollback scenario that was somewhat
wasteful.   The newer architecture of the engine has been updated so that
the connection pool "reset-on-return" logic will be skipped when the
:class:`_engine.Connection` explicitly closes out the transaction before
returning the pool to the connection.

Fixes: #6004
Change-Id: I5d2ac16cac71aa45a00b4b7481d7268bd828a168
doc/build/changelog/unreleased_14/6004.rst [new file with mode: 0644]
doc/build/core/pooling.rst
lib/sqlalchemy/engine/base.py
lib/sqlalchemy/pool/base.py
test/engine/test_deprecations.py
test/engine/test_logging.py
test/engine/test_pool.py
test/engine/test_transaction.py