]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ANDROID: binder: remove waitqueue when thread exits.
authorMartijn Coenen <maco@android.com>
Fri, 5 Jan 2018 10:27:07 +0000 (11:27 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 10 Dec 2019 18:01:28 +0000 (18:01 +0000)
commit3a593dd8bd7505f9acbc7b6f8928ec6b7978c125
tree75fc75a124af1c09b3884835e4ff5fe5e51ee87b
parenta7fd3ecd250f76407d0ff3a1454d02994909c7fc
ANDROID: binder: remove waitqueue when thread exits.

commit f5cb779ba16334b45ba8946d6bfa6d9834d1527f upstream.

binder_poll() passes the thread->wait waitqueue that
can be slept on for work. When a thread that uses
epoll explicitly exits using BINDER_THREAD_EXIT,
the waitqueue is freed, but it is never removed
from the corresponding epoll data structure. When
the process subsequently exits, the epoll cleanup
code tries to access the waitlist, which results in
a use-after-free.

Prevent this by using POLLFREE when the thread exits.

Signed-off-by: Martijn Coenen <maco@android.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
[backport BINDER_LOOPER_STATE_POLL logic as well]
Signed-off-by: Mattias Nissler <mnissler@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.16: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/staging/android/binder.c