]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove ppport.h's broken re-implementation of eval_pv().
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 9 Feb 2022 00:25:56 +0000 (19:25 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 9 Feb 2022 00:26:26 +0000 (19:26 -0500)
commit3a6e3a89022f39e0250b23635bcf5985940e6524
treefb02df99764691cdc444b0c65438e914770a5880
parentff2a6d2621439d3d3f6e340c363d3b5e71749919
Remove ppport.h's broken re-implementation of eval_pv().

Recent versions of Devel::PPPort try to redefine eval_pv() to
dodge a bug in pre-5.31 Perl versions.  Unfortunately the redefinition
fails on compilers that don't support statements nested within
expressions.  However, we aren't actually interested in this bug fix,
since we always call eval_pv() with croak_on_error = FALSE.
So, until there's an upstream fix for this breakage, just comment
out the macro to revert to the older behavior.

Per report from Wei Sun, as well as previous buildfarm failure
on pademelon (which I'd unfortunately not looked at carefully
enough to understand the cause).  Back-patch to all supported
versions, since we're using the same ppport.h in all.

Discussion: https://postgr.es/m/tencent_2EFCC8BA0107B6EC0F97179E019A8A43C806@qq.com
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelon&dt=2022-02-02%2001%3A22%3A58
src/pl/plperl/ppport.h