]> git.ipfire.org Git - thirdparty/postgresql.git/commit
oauth: Fix kqueue detection on OpenBSD
authorJacob Champion <jchampion@postgresql.org>
Mon, 7 Jul 2025 18:58:04 +0000 (11:58 -0700)
committerJacob Champion <jchampion@postgresql.org>
Mon, 7 Jul 2025 18:58:04 +0000 (11:58 -0700)
commit3a797c24914af421cf9d4d09bc90024884841dfa
tree9509a4a60f550fb5b4571368ec2b29cf67b00c3c
parent440c5ee202000a30c4e7b27cd952edb2ab16cea8
oauth: Fix kqueue detection on OpenBSD

In b0635bfda, I added an early header check to the Meson OAuth support,
which was intended to duplicate the later checks for
HAVE_SYS_[EVENT|EPOLL]_H. However, I implemented the new test via
check_header() -- which tries to compile -- rather than has_header(),
which just looks for the file's existence.

The distinction matters on OpenBSD, where <sys/event.h> can't be
compiled without including prerequisite headers, so -Dlibcurl=enabled
failed on that platform. Switch to has_header() to fix this.

Note that reviewers expressed concern about the difference between our
Autoconf feature tests (which compile headers) and our Meson feature
tests (which do not). I'm not opposed to aligning the two, but I want to
avoid making bigger changes as part of this fix.

Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/flat/CAOYmi+kdR218ke2zu74oTJvzYJcqV1MN5=mGAPqZQuc79HMSVA@mail.gmail.com
Backpatch-through: 18
meson.build