]> git.ipfire.org Git - thirdparty/bootstrap.git/commit
Carousel: use buttons, not links, for prev/next controls (#32627)
authorPatrick H. Lauke <redux@splintered.co.uk>
Wed, 27 Jan 2021 15:31:16 +0000 (15:31 +0000)
committerGitHub <noreply@github.com>
Wed, 27 Jan 2021 15:31:16 +0000 (17:31 +0200)
commit3aa3fda730ddb4d0231f4d2c83b255315f9f3684
tree183850f61f50db2cec25436b454fedbd6755f466
parent61391c4ee2f000685f39be9f0c7369142d54dd35
Carousel: use buttons, not links, for prev/next controls (#32627)

* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>
* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
js/tests/unit/carousel.spec.js
js/tests/visual/carousel.html
scss/_carousel.scss
site/content/docs/5.0/components/carousel.md
site/content/docs/5.0/examples/carousel-rtl/index.html
site/content/docs/5.0/examples/carousel/index.html