]> git.ipfire.org Git - thirdparty/systemd.git/commit
networkd: do not touch link_messages when expiring routes
authorMichael Chapman <mike@very.puzzling.org>
Thu, 18 Aug 2016 07:46:21 +0000 (17:46 +1000)
committerMichael Chapman <mike@very.puzzling.org>
Thu, 18 Aug 2016 07:53:53 +0000 (17:53 +1000)
commit3bdccf69ca626d6c2f6653044f1f68d9c9da0e42
tree236872c318d7b792ebcfc6dfdb184c4e7e503100
parent856e309d7b18cabe18c845bdf57e92958343a9ec
networkd: do not touch link_messages when expiring routes

link_messages is used during link configuration to advance the link
state machine through SETTING_ADDRESSES -> SETTING_ROUTES -> CONFIGURED.

If a route expires in the middle of this, it is possible for
link_messages to hit zero inside route_expire_callback, rather than in
route_handler or address_handler where it would trigger the next step in
configuration. Should this happen, the link will not complete
configuration, and it may not have its static routes configured.

Since route_expire_callback does not need to do anything once the
expired route has been removed from the kernel, it is safe to simply not
account for the netlink request.
src/network/networkd-route.c