]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Undo cipher push in client options state if cipher is rejected
authorSteffan Karger <steffan@karger.me>
Tue, 27 Jun 2017 22:20:29 +0000 (00:20 +0200)
committerGert Doering <gert@greenie.muc.de>
Thu, 29 Jun 2017 18:28:26 +0000 (20:28 +0200)
commit3be9a1c1cd75627c30dca05bed28c84ad4dc1d37
treed2e606a2b6136a200d774fedd284866558ee5d4e
parent7ee9a94fcbbde941bfed167229a64df0f7cdae0b
Undo cipher push in client options state if cipher is rejected

Because of the way we re-use the options parser for both config files and
pushed options, we always update the local options state when we accept an
option.  This resulted in a pushed cipher being rejected the first time it
was pushed, but being accepted the second time.

This patch is a minimal way to resolve this issue in the master and
release/2.4 branches.  I'll send a more invasive patch for master, to
reset the entire options state on reconnects, later.

Trac: #906

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20170627222029.26623-1-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14984.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/ssl.c
src/openvpn/ssl.h