]> git.ipfire.org Git - thirdparty/git.git/commit
color: use GIT_COLOR_* instead of numeric constants
authorJeff King <peff@peff.net>
Tue, 16 Sep 2025 20:13:28 +0000 (16:13 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 16 Sep 2025 20:37:03 +0000 (13:37 -0700)
commit3c3e9b830383364316ba07730aecbc47a680b513
tree0c3fd45dc4db8508d937a87c2b98de5225514682
parente335ff31f70aefc91991063cdc05967096bb1be3
color: use GIT_COLOR_* instead of numeric constants

Long ago Git's decision to show color for a subsytem was stored in a
tri-state variable: it could be true (1), false (0), or unknown (-1).
But since daa0c3d971 (color: delay auto-color decision until point of
use, 2011-08-17) we want to carry around a new state, "auto", which
bases the decision on the tty-ness of stdout (rather than collapsing
that "auto" state to a true/false immediately).

That commit introduced a set of GIT_COLOR_* defines to represent each
state: UNKNOWN, ALWAYS, NEVER, and AUTO. But it only used the AUTO
value, and left alone code using bare 0/1/-1 values. And of course since
then we've grown many new spots that use those bare values.

Let's switch all of these to use the named constants. That should make
the code a bit easier to read, as it is more obvious that we're
representing a color decision.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
21 files changed:
add-interactive.c
advice.c
builtin/add.c
builtin/am.c
builtin/branch.c
builtin/clean.c
builtin/commit.c
builtin/config.c
builtin/grep.c
builtin/push.c
builtin/range-diff.c
builtin/show-branch.c
color.c
diff.c
grep.h
parse-options-cb.c
pretty.c
ref-filter.h
sideband.c
transport.c
wt-status.c