]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Check collation when creating partitioned index
authorPeter Eisentraut <peter@eisentraut.org>
Fri, 1 Dec 2023 14:48:06 +0000 (15:48 +0100)
committerPeter Eisentraut <peter@eisentraut.org>
Fri, 1 Dec 2023 15:23:18 +0000 (16:23 +0100)
commit3c49fa2aff2c2e4ec612c97e2c44b928c8809fae
tree22094ffa1d860ab8b5356138576989fc58efae93
parentefb80468271932ad17557afa977db56bfe3e8bc5
Check collation when creating partitioned index

When creating a partitioned index, the partition key must be a subset
of the index's columns.  But this currently doesn't check that the
collations between the partition key and the index definition match.
So you can construct a unique index that fails to enforce uniqueness.
(This would most likely involve a nondeterministic collation, so it
would have to be crafted explicitly and is not something that would
just happen by accident.)

This patch adds the required collation check.  As a result, any
previously allowed unique index that has a collation mismatch would no
longer be allowed to be created.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/3327cb54-f7f1-413b-8fdb-7a9dceebb938%40eisentraut.org
src/backend/commands/indexcmds.c