]> git.ipfire.org Git - thirdparty/qemu.git/commit
net/slirp: Clean up error reporting
authorMarkus Armbruster <armbru@redhat.com>
Tue, 23 Sep 2025 09:09:53 +0000 (11:09 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 30 Sep 2025 12:43:53 +0000 (14:43 +0200)
commit3cacecb9f83754a61f4a524f686deae790e2df15
treeaa15030a00477a40f1fe4d0317eceff466c14611
parent789f1adefba726d2b0bf4d4254c829b5912e32ee
net/slirp: Clean up error reporting

net_slirp_register_poll_sock() and net_slirp_unregister_poll_sock()
report WSAEventSelect() failure with error_setg(&error_warn, ...).
error_setg_win32(&error_warn, ...) is undesirable just like
error_setg(&error_fatal, ...) and error_setg(&error_abort, ...)  are.
Replace by warn_report().

The failures should probably be errors, but these functions implement
callbacks that cannot fail, exit(1) would be too harsh, and silent
failure we don't want.  Thus, warnings.

Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-ID: <20250923091000.3180122-7-armbru@redhat.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
net/slirp.c