]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtio-snd: add max size bounds check in input cb
authorManos Pitsidianakis <manos.pitsidianakis@linaro.org>
Mon, 8 Jul 2024 07:09:49 +0000 (10:09 +0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 27 Aug 2024 19:12:40 +0000 (22:12 +0300)
commit3e08a428a795b82c40116a4b079e63017e4d57fa
treea1493340ee4713f9e593d5195d5fbff1b667c479
parent796b4c0c2425eeb972ff732bcaf669a364179900
virtio-snd: add max size bounds check in input cb

When reading input audio in the virtio-snd input callback,
virtio_snd_pcm_in_cb(), we do not check whether the iov can actually fit
the data buffer. This is because we use the buffer->size field as a
total-so-far accumulator instead of byte-size-left like in TX buffers.

This triggers an out of bounds write if the size of the virtio queue
element is equal to virtio_snd_pcm_status, which makes the available
space for audio data zero. This commit adds a check for reaching the
maximum buffer size before attempting any writes.

Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2427
Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <virtio-snd-fuzz-2427-fix-v1-manos.pitsidianakis@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 98e77e3dd8dd6e7aa9a7dffa60f49c8c8a49d4e3)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/audio/virtio-snd.c