]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Add missing error check in pgcrypto/crypt-md5.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 16 Oct 2020 15:59:13 +0000 (11:59 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 16 Oct 2020 15:59:41 +0000 (11:59 -0400)
commit3e1a4c260ef29249f412f2fcaa66c898d8d0bd7c
tree6522da94fa59507de8a57a74be66d0ea5cfed1c2
parentbc63c8704676c720266b02e59f861bdeff40e8a4
Add missing error check in pgcrypto/crypt-md5.c.

In theory, the second px_find_digest call in px_crypt_md5 could fail
even though the first one succeeded, since resource allocation is
required.  Don't skip testing for a failure.  (If one did happen,
the likely result would be a crash rather than clean recovery from
an OOM failure.)

The code's been like this all along, so back-patch to all supported
branches.

Daniel Gustafsson

Discussion: https://postgr.es/m/AA8D6FE9-4AB2-41B4-98CB-AE64BA668C03@yesql.se
contrib/pgcrypto/crypt-md5.c