]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: ti: j721e-csi2rx: Fix source subdev link creation
authorJai Luthra <jai.luthra@ideasonboard.com>
Mon, 11 Aug 2025 08:20:15 +0000 (13:50 +0530)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 25 Aug 2025 13:40:41 +0000 (15:40 +0200)
commit3e743cd0a73246219da117ee99061aad51c4748c
tree0ccb60a17afaba3739d77de5c4b3e67b96226d5e
parent929f2b69bebd860e389cc24e1f00183f53a79197
media: ti: j721e-csi2rx: Fix source subdev link creation

We don't use OF ports and remote-endpoints to connect the CSI2RX bridge
and this device in the device tree, thus it is wrong to use
v4l2_create_fwnode_links_to_pad() to create the media graph link between
the two.

It works out on accident, as neither the source nor the sink implement
the .get_fwnode_pad() callback, and the framework helper falls back on
using the first source and sink pads to create the link between them.

Instead, manually create the media link from the first source pad of the
bridge to the first sink pad of the J721E CSI2RX.

Fixes: b4a3d877dc92 ("media: ti: Add CSI2RX support for J721E")
Cc: stable@vger.kernel.org
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Tested-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com> (on SK-AM68)
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c