]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: zfcp: fix request object use-after-free in send path causing wrong traces
authorBenjamin Block <bblock@linux.ibm.com>
Tue, 2 Jul 2019 21:02:01 +0000 (23:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Jul 2019 07:12:52 +0000 (09:12 +0200)
commit3f0548a607d3c742356952a2445ccbbb8cf09fe3
treebcd58e55893ce002b1ddb6dc756924303524b9d3
parent30724adeccf63888ef684c29af09e43501653967
scsi: zfcp: fix request object use-after-free in send path causing wrong traces

commit 106d45f350c7cac876844dc685845cba4ffdb70b upstream.

When tracing instances where we open and close WKA ports, we also pass the
request-ID of the respective FSF command.

But after successfully sending the FSF command we must not use the
request-object anymore, as this might result in an use-after-free (see
"zfcp: fix request object use-after-free in send path causing seqno
errors" ).

To fix this add a new variable that caches the request-ID before sending
the request. This won't change during the hand-off to the FCP channel,
and so it's safe to trace this cached request-ID later, instead of using
the request object.

Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Fixes: d27a7cb91960 ("zfcp: trace on request for open and close of WKA port")
Cc: <stable@vger.kernel.org> #2.6.38+
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/s390/scsi/zfcp_fsf.c