]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
wwan: core: Pass string literal as format argument of dev_set_name()
authorSimon Horman <horms@kernel.org>
Wed, 23 Oct 2024 12:15:28 +0000 (13:15 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Oct 2024 18:45:54 +0000 (11:45 -0700)
commit3f7f3ef44f4b735b577291afdf7a87e6ce4b415d
treeeca11e65fbf1f6280b83137b88b99272bfe97bf1
parent9a1036389fa25cf90d58e3ae1bb0b1ad877ef1c8
wwan: core: Pass string literal as format argument of dev_set_name()

Both gcc-14 and clang-18 report that passing a non-string literal as the
format argument of dev_set_name() is potentially insecure.

E.g. clang-18 says:

drivers/net/wwan/wwan_core.c:442:34: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
  442 |         return dev_set_name(&port->dev, buf);
      |                                         ^~~
drivers/net/wwan/wwan_core.c:442:34: note: treat the string as an argument to avoid this
  442 |         return dev_set_name(&port->dev, buf);
      |                                         ^
      |                                         "%s",

It is always the case where the contents of mod is safe to pass as the
format argument. That is, in my understanding, it never contains any
format escape sequences.

But, it seems better to be safe than sorry. And, as a bonus, compiler
output becomes less verbose by addressing this issue as suggested by
clang-18.

Compile tested only.
No functional change intended.

Signed-off-by: Simon Horman <horms@kernel.org>
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Link: https://patch.msgid.link/20241023-wwan-fmt-v1-1-521b39968639@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wwan/wwan_core.c