]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: Fix some usb-controller-*-unavailable cases
authorAndrea Bolognani <abologna@redhat.com>
Tue, 5 Aug 2025 16:28:44 +0000 (18:28 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Mon, 6 Oct 2025 09:15:23 +0000 (11:15 +0200)
commit4005d83a9acbd536eae487fb18ac290a3ed6fd7a
tree23d0811b6de6d873d4f7e0c4403b78c5645d6ad5
parent9a3ff406b74f8e25ce9f22750631548146a07691
tests: Fix some usb-controller-*-unavailable cases

These tests are intended to show what happens when the device
that libvirt would use by default is not available in QEMU by
dropping the corresponding capabilities, but we're not doing
that correctly at the moment and so we still get the default
USB controller instead of a failure.

Specifically, we should be dropping all capabilities related
to devices that might be used as default or automatic USB
controllers for the machine type so that libvirt will report
an error, but for these few tests we are currently only
listing a subset of the capabilities that we should be
dropping.

Note that the usb-controller-automatic-unavailable tests are
still behaving the same despite dropping all the expected
capabilities: the reason is that, for that scenario, we're
not currently checking whether the device is available before
using it. That's a separate issue that will be addressed in an
upcoming commit.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.err [new file with mode: 0644]
tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml
tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.args [deleted file]
tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.err [new file with mode: 0644]
tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.xml
tests/qemuxmlconftest.c