]> git.ipfire.org Git - thirdparty/git.git/commit
branch: show "HEAD detached" first under reverse sort
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 7 Jan 2021 09:51:53 +0000 (10:51 +0100)
committerJunio C Hamano <gitster@pobox.com>
Thu, 7 Jan 2021 23:13:21 +0000 (15:13 -0800)
commit4045f659bdccb5108800bdc2ec96bc6f3945ff40
treec61720c100ccffe21cd5ac6568c475cacab88bd3
parent2708ce62d2105c4470399a2c839b6d451c9c148f
branch: show "HEAD detached" first under reverse sort

Change the output of the likes of "git branch -l --sort=-objectsize"
to show the "(HEAD detached at <hash>)" message at the start of the
output. Before the compare_detached_head() function added in a
preceding commit we'd emit this output as an emergent effect.

It doesn't make any sense to consider the objectsize, type or other
non-attribute of the "(HEAD detached at <hash>)" message for the
purposes of sorting. Let's always emit it at the top instead. The only
reason it was sorted in the first place is because we're injecting it
into the ref-filter machinery so builtin/branch.c doesn't need to do
its own "am I detached?" detection.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
ref-filter.c
t/t3203-branch-output.sh