]> git.ipfire.org Git - thirdparty/git.git/commit
subtree: t7900: comment subtree_test_create_repo
authorLuke Shumaker <lukeshu@datawire.io>
Tue, 27 Apr 2021 21:17:23 +0000 (15:17 -0600)
committerJunio C Hamano <gitster@pobox.com>
Wed, 28 Apr 2021 07:47:16 +0000 (16:47 +0900)
commit40b1e1ec581e5f1e6fc3c0b317c0baf3c7817c43
treea945105fc81b8dff1b6ac22d24398d522453ce5f
parentf7004069574a3d3a3fb1526c3b91448e8cb8995b
subtree: t7900: comment subtree_test_create_repo

It's unclear what the purpose of t7900-subtree.sh's
`subtree_test_create_repo` helper function is.  It wraps test-lib.sh's,
`test_create_repo` but follows that up by setting log.date=relative.  Why
does it set log.date=relative?

My first guess was that at one point the tests required that, but no
longer do, and that the function is now vestigial.  I even wrote a patch
to get rid of it and was moments away from `git send-email`ing it.

However, by chance when looking for something else in the history, I
discovered the true reason, from e7aac44ed2 (contrib/subtree: ignore
log.date configuration, 2015-07-21).  It's testing that setting
log.date=relative doesn't break `git subtree`, as at one point in the past
that did break `git subtree`.

So, add a comment about this, to avoid future such confusion.

And while at it, go ahead and (1) touch up the function to avoid a
pointless subshell and (2) update the one test that didn't use it.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/subtree/t/t7900-subtree.sh