]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gve: set xdp redirect target only when it is available
authorJoshua Washington <joshwash@google.com>
Fri, 14 Feb 2025 22:43:59 +0000 (14:43 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 19 Feb 2025 02:01:24 +0000 (18:01 -0800)
commit415cadd505464d9a11ff5e0f6e0329c127849da5
tree29769b04c518dd51f96bad33d82e86e51e2a87b3
parentf5da7c45188eea71394bf445655cae2df88a7788
gve: set xdp redirect target only when it is available

Before this patch the NETDEV_XDP_ACT_NDO_XMIT XDP feature flag is set by
default as part of driver initialization, and is never cleared. However,
this flag differs from others in that it is used as an indicator for
whether the driver is ready to perform the ndo_xdp_xmit operation as
part of an XDP_REDIRECT. Kernel helpers
xdp_features_(set|clear)_redirect_target exist to convey this meaning.

This patch ensures that the netdev is only reported as a redirect target
when XDP queues exist to forward traffic.

Fixes: 39a7f4aa3e4a ("gve: Add XDP REDIRECT support for GQI-QPL format")
Cc: stable@vger.kernel.org
Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
Reviewed-by: Jeroen de Borst <jeroendb@google.com>
Signed-off-by: Joshua Washington <joshwash@google.com>
Link: https://patch.msgid.link/20250214224417.1237818-1-joshwash@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/google/gve/gve.h
drivers/net/ethernet/google/gve/gve_main.c