]> git.ipfire.org Git - thirdparty/asterisk.git/commit
chan_sip: Don't use port derived from fromdomain if it isn't set
authorMatthew Jordan <mjordan@digium.com>
Thu, 21 Aug 2014 17:32:12 +0000 (17:32 +0000)
committerMatthew Jordan <mjordan@digium.com>
Thu, 21 Aug 2014 17:32:12 +0000 (17:32 +0000)
commit416bd82bdaf8a5cbc0c129d4b08af2af58fed067
tree6754264070b43eab14cbe3791be97034ece0476b
parentf92b7fe87d07008ea10c9d0eed3ff5b1b5cbf52f
chan_sip: Don't use port derived from fromdomain if it isn't set

If a user does not provide a port in the fromdomain setting, chan_sip will set
the fromdomainport to STANDARD_SIP_PORT (5060). The fromdomainport value will
then get used unilaterally in certain places. This causes issues with TLS,
where the default port is expected to be 5061.

This patch modifies chan_sip such that fromdomainport is only used if it is
not the standard SIP port; otherwise, the port from the SIP pvt's recorded
self IP address is used.

Review: https://reviewboard.asterisk.org/r/3893/

ASTERISK-24178 #close
Reported by: Elazar Broad
patches:
  fromdomainport_fix.diff uploaded by Elazar Broad (License 5835)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@421717 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c