]> git.ipfire.org Git - people/arne_f/kernel.git/commit
spi: trigger trace event for message-done before mesg->complete
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 18 Mar 2015 10:27:28 +0000 (11:27 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Apr 2015 12:03:03 +0000 (14:03 +0200)
commit4172dbbeb2d36551ac94ede5959000100d2bada1
tree0499ab283eb02166864942c85d15ad246700d7ed
parentf4e6c2337d11a4b8df1a3a9ef5d670839441f772
spi: trigger trace event for message-done before mesg->complete

commit 391949b6f02121371e3d7d9082c6d17fd9853034 upstream.

With spidev the mesg->complete callback points to spidev_complete.
Calling this unblocks spidev_sync and so spidev_sync_write finishes. As
the struct spi_message just read is a local variable in
spidev_sync_write and recording the trace event accesses this message
the recording is better done first. The same can happen for
spidev_sync_read.

This fixes an oops observed on a 3.14-rt system with spidev activity
after

echo 1 > /sys/kernel/debug/tracing/events/spi/enable

 .

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/spi/spi.c