]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpu: ipu-v3: prg: avoid possible array underflow
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Mar 2018 16:19:57 +0000 (17:19 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:52:15 +0000 (07:52 +0200)
commit418c85ea458a01522a2a61f5fd111043940b8e4e
tree9cbf0e242c94dd441cad3282a2443434e7320877
parent05c401183c2f55c96354be2a1174f8ae297ac1d2
gpu: ipu-v3: prg: avoid possible array underflow

[ Upstream commit 746d024c3211813946b319411aeb2b47767f8fb0 ]

gcc-8 reports that we access an array with a negative index
in an error case:

drivers/gpu/ipu-v3/ipu-prg.c: In function 'ipu_prg_channel_disable':
drivers/gpu/ipu-v3/ipu-prg.c:252:43: error: array subscript -22 is below array bounds of 'struct ipu_prg_channel[3]' [-Werror=array-bounds]

This moves the range check in front of the first time that
variable gets used.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/ipu-v3/ipu-prg.c