]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
i2c: spacemit: ensure bus release check runs when wait_bus_idle() fails
authorTroy Mitchell <troy.mitchell@linux.spacemit.com>
Thu, 25 Sep 2025 02:02:25 +0000 (10:02 +0800)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 25 Sep 2025 21:14:59 +0000 (23:14 +0200)
commit41d6f90ef5dc2841bdd09817c63a3d6188473b9b
treed25f5a1632d012ea2166b7383edce6f288ec87ef
parentb492183652808e0f389272bf63dc836241b287ff
i2c: spacemit: ensure bus release check runs when wait_bus_idle() fails

spacemit_i2c_wait_bus_idle() only returns 0 on success or a negative
error code on failure.

Since 'ret' can never be positive, the final 'else' branch was
unreachable, and spacemit_i2c_check_bus_release() was never called.

This commit guarantees we attempt to release the bus whenever waiting for
an idle bus fails.

Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC")
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/i2c/busses/i2c-k1.c