]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Revert "Allow parallel workers to cope with a newly-created session user ID."
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Aug 2024 00:56:30 +0000 (20:56 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Aug 2024 00:56:30 +0000 (20:56 -0400)
commit41fb45a482a4643e5ed44aa66f52f1512cb57ce3
tree87a4b9632350c0f442bd550d1dfc4fe9cee6b9b1
parent68855c03878c0c90227e24533ca40127da3578cd
Revert "Allow parallel workers to cope with a newly-created session user ID."

This reverts commit 68855c03878c0c90227e24533ca40127da3578cd.

Some buildfarm animals are failing with "cannot change
"client_encoding" during a parallel operation".  It looks like
assign_client_encoding is unhappy at being asked to roll back a
client_encoding setting after a parallel worker encounters a
failure.  There must be more to it though: why didn't I see this
during local testing?  In any case, it's clear that moving the
RestoreGUCState() call is not as side-effect-free as I thought.
Given that the bug f5f30c22e intended to fix has gone unreported
for years, it's not something that's urgent to fix; I'm not
willing to risk messing with it further with only days to our
next release wrap.
src/backend/access/transam/parallel.c
src/backend/commands/variable.c
src/test/regress/expected/select_parallel.out
src/test/regress/sql/select_parallel.sql