]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
crypto: powerpc - Fix initialisation of crc32c context
authorDaniel Axtens <dja@axtens.net>
Fri, 3 Mar 2017 06:56:55 +0000 (17:56 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2017 11:57:05 +0000 (12:57 +0100)
commit4310604e21dd8e87b88e0756f83e671e2d729e4f
treee91d2ce607818de38518c37936653c1b815fe7d7
parentde3c88fa6a29bd83a84df3a9184181e98f79364b
crypto: powerpc - Fix initialisation of crc32c context

commit aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213 upstream.

Turning on crypto self-tests on a POWER8 shows:

    alg: hash: Test 1 failed for crc32c-vpmsum
    00000000: ff ff ff ff

Comparing the code with the Intel CRC32c implementation on which
ours is based shows that we are doing an init with 0, not ~0
as CRC32c requires.

This probably wasn't caught because btrfs does its own weird
open-coded initialisation.

Initialise our internal context to ~0 on init.

This makes the self-tests pass, and btrfs continues to work.

Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Cc: Anton Blanchard <anton@samba.org>
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/powerpc/crypto/crc32c-vpmsum_glue.c