]> git.ipfire.org Git - thirdparty/linux.git/commit
perf probe: Fix uninitialized variable
authorJames Clark <james.clark@linaro.org>
Wed, 11 Dec 2024 08:55:23 +0000 (08:55 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 12 Dec 2024 05:40:46 +0000 (21:40 -0800)
commit434fffa926b10706f2bde2db22979d68463302fc
tree875f39992f629f42d9ffdb45e5c0f4f870e950d7
parentf7e36d02d771ee14acae1482091718460cffb321
perf probe: Fix uninitialized variable

Since the linked fixes: commit, err is returned uninitialized due to the
removal of "return 0". Initialize err to fix it.

This fixes the following intermittent test failure on release builds:

 $ perf test "testsuite_probe"
 ...
 -- [ FAIL ] -- perf_probe :: test_invalid_options :: mutually exclusive options :: -L foo -V bar (output regexp parsing)
 Regexp not found: \"Error: switch .+ cannot be used with switch .+\"
 ...

Fixes: 080e47b2a237 ("perf probe: Introduce quotation marks support")
Tested-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: James Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20241211085525.519458-2-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/probe-event.c