]> git.ipfire.org Git - thirdparty/u-boot.git/commit
mmc: s5p_sdhci: remove duplicated card detect code
authorHenrik Grimler <henrik@grimler.se>
Sun, 20 Jul 2025 17:00:26 +0000 (19:00 +0200)
committerPeng Fan <peng.fan@nxp.com>
Thu, 24 Jul 2025 04:35:34 +0000 (12:35 +0800)
commit4381d7bb3327938373dafe6b96cb98fbc5c26a49
tree325d5d3ad434402b1c941f74d21dbd6a19c75068
parent3532f1f5edfc97c9dcea723cdeb732eda44bc669
mmc: s5p_sdhci: remove duplicated card detect code

The common sdhci infrastructure is already parsing the cd-gpios
property, since commit 451931ea7002 ("mmc: sdhci: Read cd-gpio from
devicetree"). The s5p code is therefore duplicated, and also broken
since it assumes that the GPIO value is inverted, while the sdhci code
correctly follows the ACTIVE_LOW/ACTIVE_HIGH flag specified in the
device tree.

This fix was originally authored by Simon Shields:
https://github.com/fourkbomb/u-boot/commit/2eac9dea7903

The change has been tested on exynos4210-i9100, a device similar to
exynos4210-trats.

Signed-off-by: Henrik Grimler <henrik@grimler.se>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
drivers/mmc/s5p_sdhci.c