]> git.ipfire.org Git - thirdparty/openssl.git/commit
APPS: Add missing OPENSSL_free() and combine the error handler
authorJiasheng Jiang <jiasheng@purdue.edu>
Sat, 16 Mar 2024 21:27:14 +0000 (21:27 +0000)
committerTomas Mraz <tomas@openssl.org>
Tue, 9 Apr 2024 18:37:29 +0000 (20:37 +0200)
commit4394a70b8f1a6a6a5cd84b662effe72caedab5cf
treeae41317b8c9dbde3ebe93221adf7ed15eb54dd79
parent3aa6b409b021c388c87096d2aca2758e954f8358
APPS: Add missing OPENSSL_free() and combine the error handler

Add the OPENSSL_free() in the error handler to release the "*md_value"
allocated by app_malloc(). To make the code clear and avoid possible
future errors, combine the error handler in the "err" tag.
Then, we only need to use "goto err" instead of releasing the memory
separately.

Since the EVP_MD_get_size() may return negative numbers when an error occurs,
create_query() may fail to catch the error since it only considers 0 as an
error code.

Therefore, unifying the error codes of create_digest() from non-positive
numbers to 0 is better, which also benefits future programming.

Fixes: c7235be ("RFC 3161 compliant time stamp request creation, response generation and response verification.")
Signed-off-by: Jiasheng Jiang <jiasheng@purdue.edu>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/23873)

(cherry picked from commit beb82177ddcd4b536544ceec92bb53f4d85d8e91)
apps/ts.c