]> git.ipfire.org Git - thirdparty/kea.git/commit
[5058] - Addressed review comments
authorThomas Markwalder <tmark@isc.org>
Tue, 1 Nov 2016 15:00:29 +0000 (11:00 -0400)
committerThomas Markwalder <tmark@isc.org>
Tue, 1 Nov 2016 15:00:29 +0000 (11:00 -0400)
commit43ad2f493b47eaacbe7861dd00023328fa2cf359
treec9badd620492cf84ae8ef0c6ea9555daaeb09343
parent939e65e30608e72b466753aef7ba0deef5a4a742
[5058] - Addressed review comments

    Fixed typos and added decline lease checks for DHCPv6

src/lib/dhcp/duid.h
src/lib/dhcp/duid.cc
src/lib/dhcp/tests/duid_unittest.cc
    - Replaced DUID::generateEmpty() with DUID::EMPTY() which returns
    a constant reference to a static DUID instance.  This facilitates
    comparisions.
    - Updated TEST(DuidTest,empty) accordingly

src/lib/dhcpsrv/csv_lease_file6.cc
    CSVLeaseFile6::next() - added test to permit the Empty DUID
    only if state is STATE_DECLINED.

src/lib/dhcpsrv/lease.cc
    Lease6::decline() - modified to use DUID::EMPTY().

src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
    Fixed Typos

src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
    TEST_F(CSVLeaseFile6Test, declinedLeaseTest) - new test to
    verify proper handling of declined leases
src/lib/dhcp/duid.cc
src/lib/dhcp/duid.h
src/lib/dhcp/tests/duid_unittest.cc
src/lib/dhcpsrv/csv_lease_file6.cc
src/lib/dhcpsrv/lease.cc
src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc