]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sctp: set sin_port for addr param when checking duplicate address
authorXin Long <lucien.xin@gmail.com>
Fri, 24 Feb 2017 07:18:46 +0000 (15:18 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Mar 2017 11:56:56 +0000 (12:56 +0100)
commit467bec3656bde2b63b730d63e64251acde833a59
treeee13dfb5ec37aabafa5fda0dab215f2918bc1a92
parent91f4f5bfaa297434073639a42ed70e4416b11be8
sctp: set sin_port for addr param when checking duplicate address

[ Upstream commit 2e3ce5bc2aa938653c3866aa7f4901a1f199b1c8 ]

Commit b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's
bind address list") tried to check for duplicate address before copying
to asoc's bind_addr list from global addr list.

But all the addrs' sin_ports in global addr list are 0 while the addrs'
sin_ports are bp->port in asoc's bind_addr list. It means even if it's
a duplicate address, af->cmp_addr will still return 0 as the their
sin_ports are different.

This patch is to fix it by setting the sin_port for addr param with
bp->port before comparing the addrs.

Fixes: b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's bind address list")
Reported-by: Wei Chen <weichen@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sctp/protocol.c