]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:dsdb:acl: Fix LDB flags comparison
authorJennifer Sutton <jennifersutton@catalyst.net.nz>
Tue, 12 Aug 2025 01:56:16 +0000 (13:56 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 27 Aug 2025 03:41:36 +0000 (03:41 +0000)
commit468563484963216e632ea0f8cbc71aede837215e
tree317618afeb36ac7bfcbdd5b77b259802bf04904b
parent3f9f2c9efccdfc092869643ceffc2bb050858eb6
s4:dsdb:acl: Fix LDB flags comparison

LDB_FLAG_MOD_* values are not actually flags, and the previous
comparison was equivalent to

(el->flags & LDB_FLAG_MOD_MASK) == 0

which is only true if none of the LDB_FLAG_MOD_* values are set, so we
would not successfully return if the element was a DELETE. Correct the
expression to what it was intended to be.

Commit 99b805e4cbeec232c65adb1a6f3fb326b55c4496 fixed a similar issue.

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
source4/dsdb/samdb/ldb_modules/acl.c