]> git.ipfire.org Git - thirdparty/qemu.git/commit
vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset' (CVE-2021-3546)
authorLi Qiang <liq3ea@163.com>
Sun, 16 May 2021 03:04:02 +0000 (20:04 -0700)
committerMichael Roth <michael.roth@amd.com>
Mon, 18 Oct 2021 01:26:37 +0000 (20:26 -0500)
commit4787501893f8b18e84f4d72ccbea4854ad9f5c9b
treeacbada5f83f9a3c92c675821b5b9c1777393b9d3
parent07daff4a9a5f9dd6e79e3aa4a9664aee3156bd7d
vhost-user-gpu: fix OOB write in 'virgl_cmd_get_capset' (CVE-2021-3546)

If 'virgl_cmd_get_capset' set 'max_size' to 0,
the 'virgl_renderer_fill_caps' will write the data after the 'resp'.
This patch avoid this by checking the returned 'max_size'.

virtio-gpu fix: abd7f08b23 ("display: virtio-gpu-3d: check
virgl capabilities max_size")

Fixes: CVE-2021-3546
Reported-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210516030403.107723-8-liq3ea@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 9f22893adcb02580aee5968f32baa2cd109b3ec2)
Signed-off-by: Michael Roth <michael.roth@amd.com>
contrib/vhost-user-gpu/virgl.c