]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
authorJamin Lin <jamin_lin@aspeedtech.com>
Mon, 4 Aug 2025 01:46:33 +0000 (09:46 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 6 Aug 2025 07:02:36 +0000 (10:02 +0300)
commit47994cdde501a1d7ad34ed302ad2d38b890d9065
tree586313ce2c543ef241d6f635ecb21e4e3f8fcdcc
parente62a4440efe49edf703b17a96273f14b6aff2055
hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030

On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
This issue is due to the aspeed_smc_read function, which checks for the
ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was missing this
feature flag, the read operation fails and returns -1.

To resolve this, add the WDT_CONTROL feature to AST1030's feature set
so that FMC_WDT2 can be correctly accessed by firmware.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Fixes: 2850df6a81bcdc2e063dfdd56751ee2d11c58030 ("aspeed/smc: Add AST1030 support ")
Link: https://lore.kernel.org/qemu-devel/20250804014633.512737-1-jamin_lin@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
(cherry picked from commit 13ed972b4ce57198914a37217251d30fbec20e41)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/ssi/aspeed_smc.c