]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: renesas: sh_eth: Fix freeing wrong tx descriptor
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tue, 7 Sep 2021 11:29:40 +0000 (20:29 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:39:33 +0000 (12:39 +0200)
commit47b119613dcf086c4f6aa5043ae7deffb80506bf
treec665bc2386245c0d15eb025f187153a154d1e84c
parent45f8ba56d4dd9e63b9715e4dc333e83d0d81e63b
net: renesas: sh_eth: Fix freeing wrong tx descriptor

[ Upstream commit 0341d5e3d1ee2a36dd5a49b5bef2ce4ad1cfa6b4 ]

The cur_tx counter must be incremented after TACT bit of
txdesc->status was set. However, a CPU is possible to reorder
instructions and/or memory accesses between cur_tx and
txdesc->status. And then, if TX interrupt happened at such a
timing, the sh_eth_tx_free() may free the descriptor wrongly.
So, add wmb() before cur_tx++.
Otherwise NETDEV WATCHDOG timeout is possible to happen.

Fixes: 86a74ff21a7a ("net: sh_eth: add support for Renesas SuperH Ethernet")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/renesas/sh_eth.c