]> git.ipfire.org Git - thirdparty/qemu.git/commit
coroutine-lock: add limited spinning to CoMutex
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 13 Feb 2017 18:12:40 +0000 (19:12 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Tue, 21 Feb 2017 11:39:40 +0000 (11:39 +0000)
commit480cff632221dc4d4889bf72dd0f09cd35096bc1
tree8fd7a9adcdc981c7785d157d852cded18d4e9034
parentfed20a70e39bb9385020bdc4e8839d95326df8e2
coroutine-lock: add limited spinning to CoMutex

Running a very small critical section on pthread_mutex_t and CoMutex
shows that pthread_mutex_t is much faster because it doesn't actually
go to sleep.  What happens is that the critical section is shorter
than the latency of entering the kernel and thus FUTEX_WAIT always
fails.  With CoMutex there is no such latency but you still want to
avoid wait and wakeup.  So introduce it artificially.

This only works with one waiters; because CoMutex is fair, it will
always have more waits and wakeups than a pthread_mutex_t.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 20170213181244.16297-3-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
include/qemu/coroutine.h
util/qemu-coroutine-lock.c
util/qemu-coroutine.c