]> git.ipfire.org Git - thirdparty/nftables.git/commit
src: deprecate "flow table" syntax, replace it by "meter"
authorPablo Neira Ayuso <pablo@netfilter.org>
Thu, 23 Nov 2017 14:14:01 +0000 (15:14 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 24 Nov 2017 14:03:28 +0000 (15:03 +0100)
commit48661c54357aea271bf87ab2b6ef907eafc97e9a
tree9222b459849f9db7332b71866df33225d9b12920
parent932847e0c3df8f6ee3dc4478f1ef0728926d9544
src: deprecate "flow table" syntax, replace it by "meter"

According to bugzilla 1137: "flow tables" should not be syntactically
unique.

"Flow tables are always named, but they don't conform to the way sets,
maps, and dictionaries work in terms of "add" and "delete" and all that.

They are also "flow tables" instead of one word like "flows" or
"throttle" or something.

It seems weird to just have these break the syntactic expectations."

Personally, I never liked the reference to "table" since we have very
specific semantics in terms of what a "table" is netfilter for long
time.

This patch promotes "meter" as the new keyword. The former syntax is
still accepted for a while, just to reduce chances of breaking things.
At some point the former syntax will just be removed.

Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1137
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Arturo Borrero Gonzalez <arturo@netfilter.org>
15 files changed:
include/rule.h
include/statement.h
src/evaluate.c
src/expression.c
src/netlink_delinearize.c
src/netlink_linearize.c
src/parser_bison.y
src/rule.c
src/scanner.l
src/statement.c
tests/py/ip/flowtable.t
tests/py/ip/flowtable.t.payload
tests/py/ip6/flowtable.t
tests/py/ip6/flowtable.t.payload
tests/shell/testcases/sets/0022type_selective_flush_0