]> git.ipfire.org Git - thirdparty/qemu.git/commit
include/hw/i386/x86-iommu: Fix struct X86IOMMU_MSIMessage for big endian hosts
authorThomas Huth <thuth@redhat.com>
Wed, 2 Aug 2023 13:57:23 +0000 (15:57 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 4 Aug 2023 16:14:46 +0000 (19:14 +0300)
commit48be003029f18b495e33cc3714ffc84a20a4df69
tree9cb2b8c34d20b43d3e03a4ce4f7c1a71c4e800ba
parentdab9a65dfa531bdcf0b7bcaef58358b31922ffb6
include/hw/i386/x86-iommu: Fix struct X86IOMMU_MSIMessage for big endian hosts

The first bitfield here is supposed to be used as a 64-bit equivalent
to the "uint64_t msi_addr" in the union. To make this work correctly
on big endian hosts, too, the __addr_hi field has to be part of the
bitfield, and the the bitfield members must be declared with "uint64_t"
instead of "uint32_t" - otherwise the values are placed in the wrong
bytes on big endian hosts.

Same applies to the 32-bit "msi_data" field: __resved1 must be part
of the bitfield, and the members must be declared with "uint32_t"
instead of "uint16_t".

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230802135723.178083-7-thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
(cherry picked from commit e1e56c07d1fa24aa37a7e89e6633768fc8ea8705)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
include/hw/i386/x86-iommu.h