]> git.ipfire.org Git - people/arne_f/kernel.git/commit
netfilter: nf_conntrack_ipv6: Plug sk_buff leak in fragment handling
authorPhil Oester <kernel@linuxace.com>
Wed, 19 Jun 2013 10:49:51 +0000 (06:49 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2013 17:55:37 +0000 (10:55 -0700)
commit491c1b809b64748ff579ae7efe4d1cd909463504
treebb088b1e614b82c149ca4cb09de100fa3bd28b49
parentb1e1d6fc62a376b96170eee079d5560d1718bd55
netfilter: nf_conntrack_ipv6: Plug sk_buff leak in fragment handling

commit 142dcdd3c25fc7a3866bb06980e8f93a2ed7e050 upstream.

In commit 4cdd3408 ("netfilter: nf_conntrack_ipv6: improve fragmentation
handling"), an sk_buff leak was introduced when dealing with reassembled
packets by grabbing a reference to the original skb instead of the
reassembled skb.  At this point, the leak only impacted conntracks with an
associated helper.

In commit 58a317f1 ("netfilter: ipv6: add IPv6 NAT support"), the bug was
expanded to include all reassembled packets with unconfirmed conntracks.

Fix this by grabbing a reference to the proper reassembled skb.  This
closes netfilter bugzilla #823.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c