]> git.ipfire.org Git - thirdparty/qemu.git/commit
qga-win: prevent crash when executing guest-file-read with large count
authorBasil Salman <basil@daynix.com>
Wed, 11 Mar 2020 17:04:17 +0000 (19:04 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 4 Jun 2020 01:13:51 +0000 (20:13 -0500)
commit4996bd71611c756681bf3dc410957946b5f7083f
tree155697c26c47fc32dc7d4e9c28821dafd30d1516
parent3c3e1653c5c09391c154c5f36bf8646ce2bde9f9
qga-win: prevent crash when executing guest-file-read with large count

guest-file-read command is currently implemented to read from a
file handle count number of bytes. when executed with a very large count number
qemu-ga crashes.
after some digging turns out that qemu-ga crashes after trying to allocate
a buffer large enough to save the data read in it, the buffer was allocated using
g_malloc0 which is not fail safe, and results a crash in case of failure.
g_malloc0 was replaced with g_try_malloc0() which returns NULL on failure,
A check was added for that case in order to prevent qemu-ga from crashing
and to send a response to the qemu-ga client accordingly.

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1594054
Signed-off-by: Basil Salman <basil@daynix.com>
Reported-by: Fakhri Zulkifli <mohdfakhrizulkifli@gmail.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
(cherry picked from commit 807e2b6fce022707418bc8f61c069d91c613b3d2)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/commands-win32.c