]> git.ipfire.org Git - thirdparty/ipxe.git/commit
[compiler] Prevent empty weak function stubs from being removed
authorJoshua Oreman <oremanj@rwcr.net>
Wed, 18 Aug 2010 23:37:22 +0000 (16:37 -0700)
committerMichael Brown <mcb30@ipxe.org>
Thu, 19 Aug 2010 12:37:52 +0000 (13:37 +0100)
commit49d6f5700561be091b2b25bb7641708333e4911d
treeac34755391ad3025d3fd817af3696d1bca3276cf
parent059c11e1e6173fdb56f21c60932cf2e15a359f1b
[compiler] Prevent empty weak function stubs from being removed

Even with the noinline specifier added by commit 1a260f8, gcc may skip
calls to non-inlinable functions that it knows have no side
effects. This caused the get_cached_dhcpack() call in start_dhcp(),
the weak stub of which has no code in its body, to be removed,
preventing cached DHCP from working.

Fix by adding a __keepme macro to compiler.h expanding to asm(""), as
recommended by gcc's info page, and using it in the weak stub for
get_cached_dhcpack().

Reported-by: Aaron Brooks <aaron@brooks1.net>
Tested-by: Aaron Brooks <aaron@brooks1.net>
Signed-off-by: Joshua Oreman <oremanj@rwcr.net>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/include/compiler.h
src/net/udp/dhcp.c