]> git.ipfire.org Git - thirdparty/gcc.git/commit
ubsan: Fix ICEs with DECL_REGISTER tests [PR101624]
authorJakub Jelinek <jakub@redhat.com>
Wed, 28 Jul 2021 16:43:15 +0000 (18:43 +0200)
committerJakub Jelinek <jakub@redhat.com>
Wed, 28 Jul 2021 16:43:15 +0000 (18:43 +0200)
commit49e28c02a95a4bee981e69a80950309869580151
tree25cbd3dff9461094f89a830998158206f14f4d4d
parentb4fc4df94f703e3b191f503ebe7186500e45d081
ubsan: Fix ICEs with DECL_REGISTER tests [PR101624]

The following testcase ICEs, because the base is a CONST_DECL for
the Fortran parameter, and ubsan/sanopt uses DECL_REGISTER macro on it.
 /* In VAR_DECL and PARM_DECL nodes, nonzero means declared `register'.  */
 #define DECL_REGISTER(NODE) (DECL_WRTL_CHECK (NODE)->decl_common.decl_flag_0)
while CONST_DECL doesn't satisfy DECL_WRTL_CHECK.

The following patch checks explicitly for VAR_DECL/PARM_DECL/RESULT_DECL
only before using DECL_REGISTER, assumes other decls aren't DECL_REGISTER.
Not really sure about RESULT_DECL but it at least satisfies DECL_WRTL_CHECK...

2021-07-28  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/101624
* ubsan.c (maybe_instrument_pointer_overflow,
instrument_object_size): Only test DECL_REGISTER on VAR_DECLs,
PARM_DECLs or RESULT_DECLs.
* sanopt.c (maybe_optimize_ubsan_ptr_ifn): Likewise.

* gfortran.dg/ubsan/ubsan.exp: New file.
* gfortran.dg/ubsan/pr101624.f90: New test.
gcc/sanopt.c
gcc/testsuite/gfortran.dg/ubsan/pr101624.f90 [new file with mode: 0644]
gcc/testsuite/gfortran.dg/ubsan/ubsan.exp [new file with mode: 0644]
gcc/ubsan.c