]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/char: riscv_htif: Use blocking qemu_chr_fe_write_all
authorAlistair Francis <alistair.francis@wdc.com>
Tue, 13 Aug 2024 03:32:51 +0000 (13:32 +1000)
committerAlistair Francis <alistair.francis@wdc.com>
Wed, 30 Oct 2024 01:22:08 +0000 (11:22 +1000)
commit4a0e8ca322d2a5ec9bdd9409cb02d4c08a07bef6
tree37387803a8d665aaafbb8ec43f8d42b310d29083
parent2ae6cca1d3389801ee72fc5e58c52573218f3514
hw/char: riscv_htif: Use blocking qemu_chr_fe_write_all

The current approach of using qemu_chr_fe_write() and ignoring the
return values results in dropped characters [1]. Ideally we want to
report FIFO status to the guest, but the HTIF isn't a real UART, so we
don't really have a way to do that.

Instead let's just use qemu_chr_fe_write_all() so at least we don't drop
characters.

1: https://gitlab.com/qemu-project/qemu/-/issues/2114

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240910045419.1252277-2-alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/char/riscv_htif.c