]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu: Refuse setting <iotune> for 'SD' disks
authorPeter Krempa <pkrempa@redhat.com>
Thu, 25 May 2023 14:48:24 +0000 (16:48 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 5 Jun 2023 11:20:13 +0000 (13:20 +0200)
commit4ba032a2a2cd1d36e75295548c7914cf8daff8a5
tree8ee1bf9e25d105160cee6a1e88f2c4e7dcb1a179
parent6d6a87f229a40dd3da476dd1bdff5f6550a9278a
qemu: Refuse setting <iotune> for 'SD' disks

Historically this didn't work with any supported qemu version as we
don't set the alias of the device, and thus qemu uses a different alias
resulting in a failure to startup the VM:

  internal error: unable to execute QEMU command 'block_set_io_throttle': Device 'drive-sd-disk0' not found

Refuse setting throttling as this is unlikely to be needed and proper
fix requires using -device instead of -drive if=sd.

Note that this was broken when I moved the setup of throttling as a
command at startup for blockdev integration quite a while ago. Until
then throttling was passed as arguments for -drive.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c
src/qemu/qemu_validate.c