]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commit
libc-package.bbclass: Use bb.fatal() instead of raising FuncFailed
authorUlf Magnusson <ulfalizer@gmail.com>
Sat, 1 Oct 2016 02:47:07 +0000 (04:47 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 4 Oct 2016 15:29:05 +0000 (16:29 +0100)
commit4c25460c5ae3b7779ced56ce8ed114d512e1f883
tree5619c2e574ea6f07c5fed5b21dcc5fec536532c0
parentc5823be186d1ab8c36a35597e738d8578a153b16
libc-package.bbclass: Use bb.fatal() instead of raising FuncFailed

This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.

Motivating quote below:

< kergoth> the *original* intent was for the function/task to error via
           whatever appropriate means, bb.fatal, whatever, and
           funcfailed was what you'd catch if you were calling
           exec_func/exec_task. that is, it's what those functions
           raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself

FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.

(From OE-Core rev: 5369bb7fa6238cc85f0b5263519974c1a2d9eea8)

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/libc-package.bbclass