]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: ethtool: Fix suspicious rcu_dereference usage
authorKory Maincent <kory.maincent@bootlin.com>
Fri, 20 Dec 2024 08:37:40 +0000 (09:37 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Dec 2024 18:38:46 +0000 (10:38 -0800)
commit4c61d809cf608842112c77880f50810a564cd9cb
treeeb4b6caaaf125d8158cad6f46f9e58d5768a744c
parent3f8f2e93cdfb96c77bf381590dd697867e89d9e7
net: ethtool: Fix suspicious rcu_dereference usage

The __ethtool_get_ts_info function can be called with or without the
rtnl lock held. When the rtnl lock is not held, using rtnl_dereference()
triggers a warning due to the lack of lock context.

Add an rcu_read_lock() to ensure the lock is acquired and to maintain
synchronization.

Reported-by: syzbot+a344326c05c98ba19682@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/676147f8.050a0220.37aaf.0154.GAE@google.com/
Fixes: b9e3f7dc9ed9 ("net: ethtool: tsinfo: Enhance tsinfo to support several hwtstamp by net topology")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241220083741.175329-1-kory.maincent@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/common.c