]> git.ipfire.org Git - people/arne_f/kernel.git/commit
CRYPTO api: Fix potential race in crypto_remove_spawn
authorHerbert Xu <herbert@gondor.apana.org.au>
Thu, 29 Nov 2007 12:07:57 +0000 (23:07 +1100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 14 Dec 2007 18:31:58 +0000 (10:31 -0800)
commit4ccbb8f921ca871ef39c7030479cd1bbe21e4af4
tree2e7520ecf388a175cf1cd21f9a9abb35000cf1e9
parent905bc186cfa30431bd36eeb78f6dd85ff963accb
CRYPTO api: Fix potential race in crypto_remove_spawn

[CRYPTO] api: Fix potential race in crypto_remove_spawn

[ Upstream commit: 38cb2419f544ad413c7f7aa8c17fd7377610cdd8 ]

As it is crypto_remove_spawn may try to unregister an instance which is
yet to be registered.  This patch fixes this by checking whether the
instance has been registered before attempting to remove it.

It also removes a bogus cra_destroy check in crypto_register_instance as
1) it's outside the mutex;
2) we have a check in __crypto_register_alg already.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
crypto/algapi.c